-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Mutagen #842
base: main
Are you sure you want to change the base?
Optional Mutagen #842
Conversation
# Conflicts: # commands/install.cmd
Make mutagen enabled by default only for Mac OS
Load only mutagen enable flag
Load only mutagen enable flag
Check only mutagen enable flag
Fail sync command when mutagen is not enabled
Simplify appendEnvPartialIfExists
Show warning only when using OrbStack
Rename files not related to mutagen
Rename mutagen docker compose files
Move warning to warden sync command
Hi @joseluisi4, @bap14, My measurements:
So, I'm not sure if it's a good option to show a warning. For myself, I decided that it's better to keep using Mutagen sync. |
Do not show recommendation to disable Mutagen
I think it is still good to give the option to devs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I'll just need to dogfood it for a bit before merging
Check List
Describe the bug
This is a follow-up on #749
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Check List
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you've submitted
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.