Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v0.6.x remove node driver registrar lifecycle hook #72

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: v0.6.x remove node driver registrar lifecycle hook #72

merged 2 commits into from
Nov 7, 2023

Conversation

vadasambar
Copy link
Contributor

This is a port of #70 (same description applies here)

- was causing `/bin/sh not found` error
- new node driver registrar version automatically removes the socket before terminating
@vadasambar vadasambar marked this pull request as ready for review November 7, 2023 13:00
@mugdha-adhav
Copy link
Collaborator

mugdha-adhav commented Nov 7, 2023

Tested the changes by deleting a warm-metal pod and ensuring the lifecycle hook doesn't get triggered.

$ kubectl delete pod csi-image-warm-metal-2pw89
pod "csi-image-warm-metal-2pw89" deleted

$ kubectl events --for pod/csi-image-warm-metal-2pw89 --watch
LAST SEEN   TYPE     REASON      OBJECT                           MESSAGE
2m13s       Normal   Scheduled   Pod/csi-image-warm-metal-2pw89   Successfully assigned kube-system/csi-image-warm-metal-2pw89 to ip-10-133-43-42.ec2.internal
2m13s       Normal   Pulled      Pod/csi-image-warm-metal-2pw89   Container image "storage/csi:v0.6.3-1697628203" already present on machine
2m12s       Normal   Created     Pod/csi-image-warm-metal-2pw89   Created container plugin
2m12s       Normal   Started     Pod/csi-image-warm-metal-2pw89   Started container plugin
2m12s       Normal   Pulled      Pod/csi-image-warm-metal-2pw89   Container image "storage/livenessprobe:v2.3.0-1697628203" already present on machine
2m12s       Normal   Created     Pod/csi-image-warm-metal-2pw89   Created container liveness-probe
2m13s       Normal   Started     Pod/csi-image-warm-metal-2pw89   Started container liveness-probe
2m13s       Normal   Pulled      Pod/csi-image-warm-metal-2pw89   Container image "storage/csi-node-driver-registrar:v1.1.0-1697628203" already present on machine
2m13s       Normal   Created     Pod/csi-image-warm-metal-2pw89   Created container node-driver-registrar
2m13s       Normal   Started     Pod/csi-image-warm-metal-2pw89   Started container node-driver-registrar

0s          Normal   Killing     Pod/csi-image-warm-metal-2pw89   Stopping container plugin
0s          Normal   Killing     Pod/csi-image-warm-metal-2pw89   Stopping container node-driver-registrar
0s          Normal   Killing     Pod/csi-image-warm-metal-2pw89   Stopping container liveness-probe

@mugdha-adhav mugdha-adhav merged commit 12ce65d into warm-metal:0.6.x Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants