chore: reuse animation library from modal in expandable #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digitalsadhu - just quickly can you see if there's anything in the |
|
@pearofducks After running the docs locally on Safari, I noticed that the content doesn't hide/show on expand/collapse the same way it does on Chrome and Firefox. The previous implementation worked fine on Safari, which can be checked here. |
|
|
@BalbinaK - thanks for looking into this and spotting that quirk, I'll take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two primary goals in this PR:
@itsy/animatethat the Modal component uses for transitioning the title to ensure small bundle sizeexpand-transitioncomponent, might need some checks from @digitalsadhu to ensure I haven't missed something critical - but I don't understand why some of the moving parts are in the originalThis PR can safely wait for the Modal's merge, so no rush to review
(I still need to replace the element-collapse use in Toast, but I don't anticipate that being a blocker and wanted to get an RFC first on this change)