fix: Deprecate the "notification" variant of Badge (#172)

warp-ds · Jun 18, 2024 · 74bf5f2 · 74bf5f2
1 parent 1b902ba
commit 74bf5f2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/components/badge/w-badge.vue b/components/badge/w-badge.vue
@@ -15,7 +15,13 @@ const props = defineProps({
  variant: {
  type: String,
  default: 'neutral',
- validator: (value) => ['neutral', 'info', 'positive', 'warning', 'negative', 'disabled', 'notification', 'price'].includes(value),
+ validator: (value) => {
+ if (value === 'notification') {
+ console.warn('Warp Badge: The "notification" variant is deprecated - Do not use!');
+ return true;
+ }
+ return ['neutral', 'info', 'positive', 'warning', 'negative', 'disabled', 'price'].includes(value);
+ },
  },
  position: {
  type: String,

diff --git a/dev/pages/BadgeExample.vue b/dev/pages/BadgeExample.vue
@@ -12,7 +12,6 @@ const badgeVariants = [
  { name: 'warning', radio },
  { name: 'negative', radio },
  { name: 'disabled', radio },
- { name: 'notification', radio },
  { name: 'price', radio },
 ];
 const badgePositions = [