Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace letter x with icon close #129

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

felicia-haggqvist
Copy link
Contributor

@felicia-haggqvist felicia-haggqvist commented Jan 4, 2024

Fixes JIRA ticket: WARP-409

  • Replace the letter X with the IconClose16 icon in our Pill component.

@felicia-haggqvist felicia-haggqvist requested a review from a team January 4, 2024 10:51
@felicia-haggqvist felicia-haggqvist self-assigned this Jan 4, 2024
@felicia-haggqvist felicia-haggqvist marked this pull request as draft January 4, 2024 13:55
@felicia-haggqvist felicia-haggqvist marked this pull request as ready for review January 9, 2024 08:53
@felicia-haggqvist felicia-haggqvist merged commit 56763e5 into next Jan 9, 2024
5 checks passed
@felicia-haggqvist felicia-haggqvist deleted the fix/replace-x-with-icon branch January 9, 2024 14:39
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
## [1.2.4-next.1](v1.2.3...v1.2.4-next.1) (2024-01-09)

### Bug Fixes

* replace letter x with icon close ([#129](#129)) ([56763e5](56763e5))
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
## [1.2.4](v1.2.3...v1.2.4) (2024-02-15)

### Bug Fixes

* **deps:** update all dependencies (non-major) ([#132](#132)) ([c2b2131](c2b2131))
* **deps:** update dependency scroll-doctor to v2 ([#134](#134)) ([7e7e919](7e7e919))
* Remove redundant component css class from Modal ([#137](#137)) ([3d783f9](3d783f9))
* rename deleted icons after @warp-ds/icons update to 2.0.0 ([#136](#136)) ([e9ad066](e9ad066))
* replace letter x with icon close ([#129](#129)) ([56763e5](56763e5))
* Slider active track disabled state fix ([#139](#139)) ([a756c4c](a756c4c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants