Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(field): use correct colors in label and hint/error text #150

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(field): use correct colors in label and hint/error text #150

merged 3 commits into from
Mar 20, 2024

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented Mar 19, 2024 •
edited
Loading

Description

Fixes WARP-515

Changes based on the Figma component library:

  • label color doesn't change when input is invalid
  • label optional should have subtle text color (the other changes to label optional should be handled in a separate task)
  • hint/error text color should be negative when input is invalid
    Screenshot of checkbox group component with label in dark grey and help text in redScreenshot of Radio group component with label in dark grey and help text in red
Screenshot of Select component with label in dark grey and help text in red Screenshot of Select component with optional label in subtle grey

@BalbinaK
fix(field): remove invalid label color
36d04c8 
Based on the design, the label should always have the same color, even if input has invalid state
@BalbinaK
fix(field): fix hint/helpText color in invalid and regular state
4dee421
@BalbinaK BalbinaK requested a review from a team March 19, 2024 08:37
Skadefryd
Skadefryd approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Skadefryd Skadefryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@BalbinaK BalbinaK merged commit fa3a621 into next Mar 20, 2024
5 checks passed
@BalbinaK BalbinaK deleted the fix/error-text branch March 20, 2024 15:42
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
@semantic-release-bot
chore(release): 1.2.6-next.3 [skip ci]
dceec15 
## [1.2.6-next.3](v1.2.6-next.2...v1.2.6-next.3) (2024-03-20)

### Bug Fixes

* **w-field:** use correct colors in label and hint/error text ([#150](#150)) ([fa3a621](fa3a621))
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@semantic-release-bot
chore(release): 1.2.6 [skip ci]
b90f466 
## [1.2.6](v1.2.5...v1.2.6) (2024-03-21)

### Bug Fixes

* add missing aria attribute to w-textarea and w-select ([#146](#146)) ([191be0f](191be0f))
* **w-field:** ensure default error text is translated on time ([#148](#148)) ([36dcf1c](36dcf1c))
* **w-field:** use correct colors in label and hint/error text ([#150](#150)) ([fa3a621](fa3a621))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicia-haggqvist felicia-haggqvist felicia-haggqvist approved these changes

@Skadefryd Skadefryd Skadefryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BalbinaK @Skadefryd @felicia-haggqvist