Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issues with validation messages for input fields #155

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

magnuh
Copy link
Collaborator

@magnuh magnuh commented Apr 9, 2024

  • Make sure validation messages are reactive.
  • Do not show required error message for optional fields.

Reported here: https://sch-chat.slack.com/archives/C04P0GYTHPV/p1712657177643739?thread_ts=1712593230.715119&cid=C04P0GYTHPV

@magnuh magnuh requested a review from a team April 9, 2024 13:07
@magnuh magnuh self-assigned this Apr 9, 2024
Copy link
Contributor

@BalbinaK BalbinaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 💪

@magnuh magnuh merged commit 9a26bfa into next Apr 9, 2024
4 checks passed
@magnuh magnuh deleted the fix-validation-message-issues branch April 9, 2024 13:18
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.2.7-next.1](v1.2.6...v1.2.7-next.1) (2024-04-09)

### Bug Fixes

* Fix issues with validation messages for input fields ([#155](#155)) ([9a26bfa](9a26bfa))
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
## [1.2.7](v1.2.6...v1.2.7) (2024-04-09)

### Bug Fixes

* Fix issues with validation messages for input fields ([#155](#155)) ([9a26bfa](9a26bfa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants