Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textfield/textarea): clean up classes #163

Merged
merged 8 commits into from
May 14, 2024
Merged

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented May 3, 2024

Description

Use cleaned up input component classes to avoid buggy style overriding when utility classes styling the same CSS properties were applied to the same element

Changes included

  • Update @warp-ds/uno to 1.12.0 in order to handle padding classes with arbitrary values that contain CSS variables (e.g. pl-[var(--w-prefix-width,_40px)]
  • Use the cleaned up input component classes to avoid style overriding
  • Set the pnpm version to v9 in github workflows to avoid lockfile issues after updating pnpm locally

Testing

Tested with TextField and Textarea.
Gif representing TextField in different states behaving and looking the same as before

@BalbinaK BalbinaK requested a review from a team May 3, 2024 10:14
Copy link
Contributor

@felicia-haggqvist felicia-haggqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

…npm@9.1.1

The packageManager value will need to be updated each time we update pnpm locally. Otherwise we can set the
"package-manager-strict" configuration to "false" in .npmrc
@BalbinaK BalbinaK merged commit 2babe15 into next May 14, 2024
6 checks passed
@BalbinaK BalbinaK deleted the fix/cc/textfield-textarea branch May 14, 2024 12:58
github-actions bot pushed a commit that referenced this pull request May 14, 2024
# [2.0.0-next.4](v2.0.0-next.3...v2.0.0-next.4) (2024-05-14)

### Bug Fixes

* **textfield/textarea:** clean up classes  ([#163](#163)) ([2babe15](2babe15))
github-actions bot pushed a commit that referenced this pull request May 15, 2024
# [2.0.0](v1.2.7...v2.0.0) (2024-05-15)

### Bug Fixes

* Styling fixes for Card component ([#157](#157)) ([646fcc4](646fcc4))
* **textfield/textarea:** clean up classes  ([#163](#163)) ([2babe15](2babe15))

### Features

* add more functionality to attention component ([#161](#161)) ([a8ed8ab](a8ed8ab))
* Individual imports ([#162](#162)) ([42c72d5](42c72d5))
* test release ([#160](#160)) ([85bf2d6](85bf2d6)), closes [#2](#2)

### BREAKING CHANGES

* The attention component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants