fix(cc): no classes styling the same CSS properties are set on one element #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(tabs): simplify component classes and restore bottom border * chore: install component-classes-cleanup branch version of @warp-ds/css
* fix(select): clean up component classes * fix: refactor computed functions in w-select + add example of select read-only * fix: refactor functions * fix: add handleKeyDown() function to disable space, arrowDown and arrowUp when readOnly prop is set to true * fix: run pnpm lint * fix: update pnpm-lock-file to get latest version of github:warp-ds/css#component-classes-cleanup * fix: fix broken test by reverting updating vitest/happy-dom-dependencies
* fix(steps): clean up classes * fix(steps): revert formatting icon-check-16 * fix(steps): revert removing export default of wSteps * fix(step): update classnames * fix(step): fix after comments * fix(step): fix linting errors * fix(step): reorder classes
* fix(slider): clean up classes * fix(slider): update to latest version of css component-classes-cleanup
* fix(expandable): clean up classes * fix(expandable): revert creating redundant toggleExpandable function * fix(expandable): remove deprecated ccExpandable.chevronBox class * fix(expandable): add props.info to contentClasses * fix(expandable): use ccExpandable.title class and replace expandableTitle class with titleType * fix(expandable): remove deprecated info prop BREAKING CHANGE: info prop has been removed * fix(expandable): replace paddingTop with contentWithTitle * fix(expandable): revert removing setTimeout and showChevronUp
* fix(card): clean up classes * fix(card): make backgroundClass into a computed * fix(card): remove backgroundClass and rename ccCard.card to ccCard.base * fix(card): update to latest version of css component-classes-cleanup * fix(card): refactor combined ternary expression into two
* fix: update classnames * fix: fix linting issue * refactor: clean up components Use same way for applying classNames and remove repetitive code * fix(switch): update classnames * fix: rename buttonClasses to just classes since it can also be an anchor tag * fix(tabs): update tests * refactor(switch): refactor condition in trackClasses * refactor(tab): refactor tabClasses * refactor(button): refactor classes * refactor(button): refactor again classes * refactor(button): move props.href condition from linkclasses to classes * fix: update to latest version of css component-classes-cleanup
* fix(tabs/steps): rename container keys in component classes * fix(buttongroup): rename unSelected key with unselected * refactor: update to latest version of css component-classes-cleanup
imprashast
approved these changes
Aug 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
# [3.0.0-next.2](v3.0.0-next.1...v3.0.0-next.2) (2024-08-13) ### Bug Fixes * **cc:** no classes styling the same CSS properties are set on one element ([#192](#192)) ([26f0f67](26f0f67))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
# [3.0.0-next.1](v2.1.0-next.3...v3.0.0-next.1) (2024-08-13) ### Bug Fixes * **cc:** no classes styling the same CSS properties are set on one element ([#191](#191)) ([030c4bb](030c4bb)) * **cc:** no classes styling the same CSS properties are set on one element ([#192](#192)) ([26f0f67](26f0f67)) * Revert "release: 3.x.x" ([12071a4](12071a4)) * revert c00a864 ([c6b9b97](c6b9b97)) ### BREAKING CHANGES * **cc:** Expandable info prop has been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures no classes styling the same CSS properties are being set on the same HTML element.
Note:
Testing
Tested the changes in Chrome, Safari and Firefox