fix: Remove instances of process variable from build output #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalbinaK
reviewed
Aug 15, 2024
BalbinaK
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Should icons be released as stable before merging?
If that's required to properly test whether this change fully works on Eik, then I'd say it makes sense to make a stable release of @warp-ds/icons and update it here.
Should we test this with the team that reported this first before doing all stable release?
I'd say it would help us see right away if this actually fixes the previous issues. Can they test using the -next.x version of Vue from Eik?
|
Yeah lets ask them to test with the next version first 👍 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
## [2.1.1-next.1](v2.1.0...v2.1.1-next.1) (2024-08-15) ### Bug Fixes * Remove instances of process variable from build output ([#194](#194)) ([b2c0ff9](b2c0ff9))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
## [2.1.1](v2.1.0...v2.1.1) (2024-08-20) ### Bug Fixes * Remove instances of process variable from build output ([#194](#194)) ([b2c0ff9](b2c0ff9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will basically fix the issue with process variable ending up on the browser bundle.
Should icons be released as stable before merging?
or
Should we test this with the team that reported this first before doing all stable release?