-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.1 #64
Merged
Release 1.0.1 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more but it is own button type (#63)
siljec
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I think we should include this change before merging. It fixes a bug that the previous commits would introduce 😊 |
Fixes issues where buttons receiving only modifier props like small, loading, quiet (without any variant prop) weren't applying any classes. The default button variant in such case should be "secondary".
## [1.0.1-next.1](v1.0.0...v1.0.1-next.1) (2023-09-18) ### Bug Fixes * add test case for negative button as it is not just modifier anymore but it is own button type ([#63](#63)) ([c9d4950](c9d4950)) * **buttons:** set secondary variant styles by default ([#67](#67)) ([cde4077](cde4077)) * use new button classes and improve conditions ([#62](#62)) ([1c9fa6c](1c9fa6c))
There was a bug with v1.0.1-next.1 tag pointing at a wrong commit hash, which resulted in the last two releases to NPM fail. This bug was caused by an attempt to update a semantic-release-bot commit and force-pushing it to 'next' branch. The commit hash changed and so semantic release had no reference to the commit tagged by v1.0.1-next.1. The solution was to force-update the referenced commit hash in v1.0.1-next.1 tag.
## [1.0.1-next.1](v1.0.0...v1.0.1-next.1) (2023-09-18) ### Bug Fixes * add test case for negative button as it is not just modifier anymore but it is own button type ([#63](#63)) ([c9d4950](c9d4950)) * **buttons:** set secondary variant styles by default ([#67](#67)) ([cde4077](cde4077)) * **changelog:** remove changes related to unreleased commits ([#68](#68)) ([364a355](364a355)) * use new button classes and improve conditions ([#62](#62)) ([1c9fa6c](1c9fa6c))
## [1.0.1-next.1](v1.0.0...v1.0.1-next.1) (2023-09-19) ### Bug Fixes * add test case for negative button as it is not just modifier anymore but it is own button type ([#63](#63)) ([c9d4950](c9d4950)) * **buttons:** set secondary variant styles by default ([#67](#67)) ([cde4077](cde4077)) * **changelog:** remove changes related to unreleased commits ([#68](#68)) ([364a355](364a355)) * update test for a button and changelog ([#69](#69)) ([4eb675e](4eb675e)) * use new button classes and improve conditions ([#62](#62)) ([1c9fa6c](1c9fa6c))
## [1.0.1-next.2](v1.0.1-next.1...v1.0.1-next.2) (2023-09-19) ### Bug Fixes * add test case for negative button as it is not just modifier anymore but it is own button type ([#63](#63)) ([c9d4950](c9d4950)) * **buttons:** set secondary variant styles by default ([#67](#67)) ([cde4077](cde4077)) * **changelog:** remove changes related to unreleased commits ([#68](#68)) ([364a355](364a355)) * remove useless test and update changelog ([#70](#70)) ([4ea3fdc](4ea3fdc)) * update test for a button and changelog ([#69](#69)) ([4eb675e](4eb675e))
## [1.0.1-next.3](v1.0.1-next.2...v1.0.1-next.3) (2023-09-20) ### Bug Fixes * make tabs accessible for using keyboard keys again ([#71](#71)) ([14129cc](14129cc))
* fix: Add fullWidth prop to w-button component * add fullWidth modifier to Button-component
## [1.0.1-next.4](v1.0.1-next.3...v1.0.1-next.4) (2023-09-20) ### Bug Fixes * Add fullWidth button prop ([#72](#72)) ([f0e76e8](f0e76e8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.