refactor(services): add kind and params #13
Conversation
app/Global.scala
Outdated
| import play.api.Configuration | ||
| import scala.concurrent.duration._ | ||
| import scala.concurrent.ExecutionContext | ||
| import play.api.{Configuration, _} |
There was a problem hiding this comment.
Maybe just import play.api._ then? (or maybe import only what you actually need)
app/models/OrderService.scala
Outdated
| checks.map(checkToOrder(service)) | ||
| check.kind match { | ||
| case HTTP => { | ||
| val params = check.params.getOrElse[Params](HTTPCheckParams(true, "/")) match { |
There was a problem hiding this comment.
The pattern matching is unnecessary here, you already do this with the getOrElse
app/models/Scheduler.scala
Outdated
| val buckets = toto.bucketize(orders, 50) | ||
| def handleChecks(services: List[CompleteService], tick: Tick) = { | ||
| val orders = services.flatMap(service => or.getOrders(service, tick.kind)) | ||
| val buckets = SchedulerInstances.bucketize(orders, 50) |
There was a problem hiding this comment.
This 50 number worked fine with HTTP only. Now though this should be the interval between each tick for that kind of check, minus a few seconds.
app/models/Scheduler.scala
Outdated
| object SchedulerInstances { |
There was a problem hiding this comment.
That name does not make much sense here, I guess the bucketize function should just go in the Scheduler companion object.
| .map({ case (s, vs) => CompleteService(s, vs.map(_._2))}) | ||
| .toList | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure why you moved this block? Not that it matters much, it just complicates the diff and makes git blaming a bit harder.
There was a problem hiding this comment.
The formatter was excited. I will remove this changes.
FlorentinDUBOIS
force-pushed
the
refactor/service
branch
4 times, most recently
from
f414c38 to
5a43ec5
Compare
FlorentinDUBOIS
force-pushed
the
refactor/service
branch
from
83de91f to
3010622
Compare
No description provided.