Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add expiry option to tickets #924

Closed
Emiliaaah opened this issue Dec 2, 2023 · 4 comments · Fixed by #957
Closed

Feat: add expiry option to tickets #924

Emiliaaah opened this issue Dec 2, 2023 · 4 comments · Fixed by #957
Labels
type/feature

Comments

@Emiliaaah
Copy link

It would be awesome if I could give someone a token with which they can log in for a certain period of time. So only give someone the option to use the ticket for the next 30 minutes. Something that would kind of go along side this would be single use tickets.
@vvrein
Copy link

vvrein commented Jan 3, 2024

And the "oneshot" tickets would be nice feature.

@kakawait
Copy link
Contributor

I've checked the code, and seems that both feature expiration and number of usage already part of model of the ticket.
Maybe is just missing UI?

@Eugeny
Copy link
Member

Eugeny commented Feb 28, 2024

Yes - it was already implemented, just not available to configure through the UI yet

@kakawait
Copy link
Contributor

I'll try to contribute on that. But don't block yourself to do it if you want because I'm totally new in rust and svelte so can take some time

kakawait added a commit to kakawait/warpgate that referenced this issue Feb 29, 2024
@kakawait
Enhance ticket creation api and UI to support ticket expiry
546fac1 
Ticket expiry was already supported on core but no way to defined it, neither from UI neither from API

Changed API to accept new optional field `expiry` and update UI form to be able to set it from UI

closes warp-tech#924
@kakawait kakawait mentioned this issue Feb 29, 2024
Merged
Eugeny pushed a commit that referenced this issue Mar 1, 2024
@kakawait
Enhance ticket creation api and UI to support ticket expiry (#957)
257fb38 
Ticket expiry was already supported on core but no way to defined it,
neither from UI neither from API

Changed API to accept new optional field `expiry` and update UI form to
be able to set it from UI

closes #924
kakawait added a commit to kakawait/warpgate that referenced this issue Mar 3, 2024
@kakawait
Enhance ticket creation api and UI to support ticket number of usage
0289cdd 
Ticket uses left was already supported on core but no way to defined it,
neither from UI neither from API

Changed API to accept new optional field  and update UI form to
be able to set it from UI

related warp-tech#924
@kakawait kakawait mentioned this issue Mar 3, 2024
Merged
Eugeny added a commit that referenced this issue Mar 4, 2024
@kakawait @Eugeny
Enhance ticket creation api and UI to support ticket number of usage (#…
f3dc1ad 
…959)

Ticket uses left was already supported on core but no way to defined it,
neither from UI neither from API

Changed API to accept new optional field and update UI form to be able
to set it from UI

related #924

---

UI changes

<img width="1370" alt="Screenshot 2024-03-04 at 00 15 11"
src="https://github.com/warp-tech/warpgate/assets/275609/76510a58-e232-46af-bf50-9444e5950507">
<img width="1360" alt="Screenshot 2024-03-04 at 00 13 58"
src="https://github.com/warp-tech/warpgate/assets/275609/814d2ce2-6f6c-48eb-b066-ecec039530fc">

---------

Co-authored-by: Eugene <inbox@null.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance ticket creation api and UI to support ticket expiry kakawait/warpgate
4 participants
@Eugeny @kakawait @vvrein @Emiliaaah