Lazygit sometimes does not come back after external commit command

[Bringoff]

Discord username (optional)

No response

Describe the bug

In my git flow I use https://github.com/jesseduffield/lazygit, https://github.com/zyedidia/micro and some hooks.
I always use lazygit command "commit changes with external git editor" because lazygit itself does not honor commit message hooks. 
And when after a successful commit I try to return to lazygit, I often get just a blank screen. 
Didn't happen a single time with Iterm, so I suppose it has something to do with Warp's terminal UI support.

To Reproduce

Steps to reproduce:

1. From opened lazygit, perform "commit changes with external git editor"
2. Wait for pre-commit hook to finish (gradle task in my case)
3. Write commit message in micro, that pops up after hook finishes successfully
4. Press "Enter" when "Press Enter to return to lazygit" prompt appears

Expected behaviour

Lazygit should open, but sometimes I just get blank Warp tab instead

Screenshots

No response

Operating System

MacOS

OS Version

12.4

Shell Version

zsh 5.8.1 (x86_64-apple-darwin21.0)

Warp Version

v0.2022.06.13.09.15.stable_00

Additional context

No response

Warp Internal (ignore): linear-label:24888f54-df93-45d5-9bdd-e38f740cac19

No response

[elviskahoro]

Thanks for reporting. will circle back when there are updates!

[undefined512]

I have the same problem. Steps to reproduce: From opened lazygit, I commit some files -> husky automatic run -> some files fail lint -> I press "Enter" when "Press Enter to return to lazygit" prompt appears -> I always get blank Warp tab, cannot type anything.

Operating System: MacOS
OS Version: 11.7
Shell Version: zsh 5.8 (x86_64-apple-darwin20.0)
Warp Version: v0.2022.09.27.08.11.stable_00

[cfurrow]

I've also experienced this issue, and wondering if this could potentially be an issue with the underlying library that lazygit uses to make itself an interactive terminal application: https://github.com/jroimartin/gocui

I don't know enough about how lazygit (or gocui) work to understand why Warp would be misinterpreting re-rendering the view/terminal, and rendering a blank screen.

It my most recent test, when I get to the "blank screen" after attempting to commit, lazygit starts to use more and more CPU (passing 100%). So it's like lazygit is stuck in a loop when it's rendering the blank screen.

mkdir lazygit-warp-test
cd lazygit-warp-test
git init
touch .gitignore
lazygit
# add and attempt to commit .gitignore
# note: i have git sign my commits with SSH keys, and my SSH-agent is 1password (protects and stores my ssh private keys)
# lazygit renders blank screen and begins to ramp up CPU usage

I don't see any helpful logs in macOS's Console app. I don't see anything from Warp, lazygit, git, etc.

Additionally, commands like <CTRL-C> or <CTRL-Z> have no effect. The Warp terminal tab does not seem to accept any new commands or key combinations, so the tab must be closed, and re-opened.

Here's a quick recording of the process, in case it helps someone else understand the issue:

This identical process does not fail in other terminal apps (Hyper or iTerm), but that's to be expected.

[cfurrow]

A current "workaround" is to use a terminal multiplexer, like zellij (or possibly tmux). Running lazygit from inside of zellij does not seem to have the same issues as running lazygit directly in warp.

[cfurrow]

It may be the case that the fix for #833 (which was merged yesterday or today) has fixed this current issue as well! In my own testing, I could use lazygit within warp (not in a sub shell, or multiplexer), and I was able to commit changes and not have lazygit return a blank screen back.

Would be curious if other people have the same experience as me!

[dannyneira]

Thanks for letting us know @cfurrow
@Bringoff are you seeing the same fix in lazygit after the most recent update to Warp?

[Bringoff]

I've been trying the latest update with lazygit today, no blank tab so far 👍

[vorporeal]

Glad to hear it's working as expected now! Going to close out this issue, but don't hesitate to re-open it if things aren't working for you on the latest version!

[alfonsocj]

👋 I'm getting exactly this issue now on Warp v0.2024.12.03.08.02.stable_04 and lazygit 0.44.1.

[ManeFunction]

Can confirm this back on Warp v0.2024.12.10.15.55.stable_04 and lazygit 0.44.1 just after making any commit :(