Update octokit dependency #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bnavetta I think we should have @alokedesai review this since he made this workflow |
alokedesai
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Octokit to address https://github.com/warpdotdev/generate-changelog/security/dependabot/19.
I don't think we use the webhook component of Octokit directly, but it should be safer to upgrade. This also updates
ncc, because older versions run into this issue on Node versions greater than 16.I tested by running
npm run all(and reverting the formatting changes togenerate-changelog.ts). This is a major version upgrade of Octokit, but the TypeScript compiler didn't flag any breaking API changes.