Skip to content

Conversation

@vorporeal
Copy link

Description

WISOTT.

We need this in order to be able to catch device loss errors using an error scope and handle them gracefully.

Testing

  • Tested by adding the following code at the start of present() that unconditionally produces a DeviceError::Lost and verified that Warp will detect it and try to recreate the renderer.
let error = SurfaceError::Device(wgc::device::DeviceError::Lost);
self.context
    .handle_error_nolabel(&self.error_sink, error, "Surface::present");

@vorporeal vorporeal requested a review from acarl005 February 20, 2025 17:11
@vorporeal vorporeal merged commit 58b2f07 into warpdotdev/v24 Feb 20, 2025
56 checks passed
vorporeal added a commit that referenced this pull request Oct 3, 2025
* Make Surface::present() errors non-fatal.

* Remove code used for testing.

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants