fix parsing CRLF files, part 3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing can be easy or nice, can it. On the plus side, some tests are unskipped now and actually hold up some standards and expectations. That's nice.
mvdan
approved these changes
Sep 25, 2021
| func normalizeEndings(in []byte) []byte { | ||
| if bytes.Count(in, sigilCrLf) == 0 { | ||
| return in | ||
| } |
There was a problem hiding this comment.
I imagine bytes.Replace is already smart enough to return the input unchanged if there are no matches
There was a problem hiding this comment.
Oddly enough, it does specifically the opposite: it always returns a copy.
(I initially had the same expectation you did!)
There was a problem hiding this comment.
Ah, it's documented to "return a copy", so that makes sense. Weird docs though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing can be easy or nice, can it.
Dogpiling on #4 and #3 . I think this is addressing the last of the things we've discovered through that journey.
Most of the diff is just me commenting crankily, as is natural.
On the plus side, some tests are unskipped now and actually hold up some standards and expectations. That's nice.