Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: output format with and without --no-color option are different #86

Closed
atezet opened this issue Oct 30, 2019 · 0 comments · Fixed by #91
Closed

Bug: output format with and without --no-color option are different #86

atezet opened this issue Oct 30, 2019 · 0 comments · Fixed by #91
Assignees
@roaldnefs
Labels
Priority: Low Type: Bug Something isn't working

Comments

@atezet
Copy link
Contributor

atezet commented Oct 30, 2019

The --nocolor option does not only disable colours, it also removes the square brackets around the rule ID:

$ salt-lint init.sls
[203] Most files should not contain tabs
init.sls:7
	- test

$ salt-lint --nocolor init.sls
203 Most files should not contain tabs
init.sls:7
	- test
@roaldnefs roaldnefs added Priority: Low Type: Bug Something isn't working labels Oct 31, 2019
roaldnefs added a commit that referenced this issue Oct 31, 2019
@roaldnefs
Fix format string to use square brackets
fdcfd7c 
Fix format string to also use square brackets with the `--nocolor`
option.

Fixes #86.

Signed-off-by: Roald Nefs <roald@warpnet.nl>
@roaldnefs roaldnefs mentioned this issue Oct 31, 2019
Merged
@roaldnefs roaldnefs self-assigned this Nov 1, 2019
This was referenced Nov 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roaldnefs roaldnefs

Labels
Priority: Low Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 0.1.0 Release warpnet/salt-lint
2 participants
@atezet @roaldnefs