feat: add frequent typo-catching rules #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I put those rules as 'formatting' though we may have 'typos' category maybe.. |
|
👋 Hi @jay7x! Thanks for your PR! We are currently a bit short on time, but we'll try to look at your code soon. |
|
Ah! I see.. I missed somehow that BAD_XXX_LINE & GOOD_XXX_LINE are different for every test :-D |
As Salt is unable to catch some frequent typos there are few checks: - "onchange" (must be "onchanges") - "requires" (must be "require") - "content" (must be "contents")
jbouter
approved these changes
May 2, 2021
|
Approved on my end, but I'd like a review by @roaldnefs as well. |
|
Any chance for this PR to be merged or declined soon? :-D |
Simplify the typographical error rules by creating a base `TypographicalErrorRule` that can be extended by a simple regex. This commit also adds the missing `CHANGELOG.md` entry. Signed-off-by: Roald Nefs <info@roaldnefs.com>
roaldnefs
approved these changes
May 31, 2021
roaldnefs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Salt is unable to catch some frequent typos there are few checks: