Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh tries to download 1.1.0 instead of v1.1.0 #394

Closed
d33psky opened this issue Apr 25, 2024 · 3 comments · Fixed by #405
Closed

install.sh tries to download 1.1.0 instead of v1.1.0 #394

d33psky opened this issue Apr 25, 2024 · 3 comments · Fixed by #405

Comments

@d33psky
Copy link
Contributor

d33psky commented Apr 25, 2024

install tries this url

https://github.com/warrensbox/terraform-switcher/releases/download/v1.1.0/terraform-switcher_1.1.0_linux_amd64.tar.gz

while the url should be

https://github.com/warrensbox/terraform-switcher/releases/download/v1.1.0/terraform-switcher_v1.1.0_linux_amd64.tar.gz

note the missing v in the second 1.1.0
d33psky added a commit to d33psky/terraform-switcher that referenced this issue Apr 25, 2024
@d33psky
this fixes issue warrensbox#394
f6916cb
warrensbox added a commit that referenced this issue Apr 25, 2024
@warrensbox
Merge pull request #395 from d33psky/HL-fix-install
44821f3 
this fixes issue #394
@d33psky
Copy link
Contributor Author

d33psky commented Apr 25, 2024

this issue is now confirmed fixed for the new v style,
but it breaks for older versions

@warrensbox
Copy link
Owner

warrensbox commented Apr 25, 2024 •
edited
Loading

This is fixed for the latest release v1.1.0.

Thanks for the fix @d33psky !

@warrensbox
Copy link
Owner

We would need to refactor the install.sh script so that it would work with or without "v". For now, the latest code should work.

@d33psky d33psky closed this as completed Apr 25, 2024
kunzese added a commit to kunzese/pkgbuilds that referenced this issue Apr 25, 2024
@kunzese
fix(tfswitch): handle new v-prefix
6b6b1b0 
See warrensbox/terraform-switcher#394
kunzese added a commit to kunzese/pkgbuilds that referenced this issue Apr 25, 2024
@github-actions @kunzese
chore(tfswitch): bump version to 1.1.0 (#29)
2cdf38a 
* chore(tfswitch): bump version to 1.1.0

* fix(tfswitch): handle new v-prefix

See warrensbox/terraform-switcher#394

* fix(tfswitch): add v-prefix in build step

* ci: fix `error obtaining VCS status`

---------

Co-authored-by: Sebastian Kunze <mail@sebastiankunze.de>
@yermulnik yermulnik mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Adjust install.sh for new tagging format warrensbox/terraform-switcher
2 participants
@d33psky @warrensbox