Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows #262

Closed
wants to merge 1 commit into from
Closed

Fix Windows #262

wants to merge 1 commit into from

Conversation

ziggy471
Copy link

Fix binpath
Fix arrow keys

@ziggy471
Copy link
Author

Fix #199

yermulnik
yermulnik approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kennedy kennedy mentioned this pull request Oct 11, 2022
Closed
@sworisbreathing
Copy link

ping @jukie @warrensbox - any chance of getting a review on this one any time soon? I'm keen to move from my homegrown scripts to tfswitch but not sure it'll work on windows without this PR

@ionstormadi
Copy link

ping @jukie @warrensbox - any chance of getting a review on this one any time soon please.

@Navacio
Copy link

Navacio commented Apr 3, 2023

Any chance we can get this pulled in? I can continue to cherry pick but its no fun. @warrensbox @jukie

@warrensbox
Copy link
Owner

Will merge by this week '

@sworisbreathing
Copy link

Thanks @warrensbox. Will #267 also be reviewed/merged?

@yermulnik
Copy link
Collaborator

@ziggy471 Apologies for this PR left unmerged =( Has by any chance the #327 resolved what this PR of yours was meant for? If not, please re-open.

@yermulnik yermulnik closed this Apr 5, 2024
@ziggy471
Copy link
Author

ziggy471 commented Apr 5, 2024

@yermulnik Haven't even bothered checking the other PR, we gave up trying to have the IT guys manage TF, now just DevOps,, so no need for Windows anymore. This was just my 5 minute attempt to make it work on their machines.

@systematicguy
Copy link

systematicguy commented Apr 5, 2024 •
edited
Loading

Respectfully, I am very much anticipating a fix for windows. ^^ Will test next workeeek how the newest version is doing.

@systematicguy
Copy link

Tested v1.1.1, works now! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermulnik yermulnik yermulnik approved these changes

@jukie jukie Awaiting requested review from jukie jukie is a code owner

@warrensbox warrensbox Awaiting requested review from warrensbox warrensbox is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ziggy471 @sworisbreathing @ionstormadi @Navacio @warrensbox @yermulnik @systematicguy