-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging refactoring #350
Logging refactoring #350
Conversation
4af5df3
to
13a066b
Compare
Here are some example outputs What do you think regarding that new output @warrensbox |
I like it. Especially if add colors to messages. It also standardizes logging across the whole app which great. |
13a066b
to
c747205
Compare
c747205
to
8138f0f
Compare
8138f0f
to
3439ab1
Compare
@MatrixCrawler please go ahead and add the color output. Otherwise, all look good |
8a85298
to
0d07397
Compare
I did add the color to the output configuration. |
Looks nice. |
We will.. there are \n on some log messages. Will remove them |
Just wanted to post the same about newlines =) |
I'm fine with both =) |
Amazing ❤️ |
Then this is ready for next review round |
e445483
to
f695ab9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attempted to align all logger messages between each other. Hope you don't mind.
Please feel free to adjust where and if necessary.
Thanks. Much appreciated 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@warrensbox Are you ok with this change?
@MatrixCrawler Could you please resolve merge conflict and we should be good to merge. |
- consolidate logging in the application
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
aa2f246
to
2bb4acb
Compare
This is an attempt to use a logger for output information and consolidate the different outputs.