Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RECENT to JSON Proposal #437

Merged
merged 19 commits into from
Jun 4, 2024
Merged

RECENT to JSON Proposal #437

merged 19 commits into from
Jun 4, 2024

Conversation

MatrixCrawler
Copy link
Collaborator

@MatrixCrawler MatrixCrawler commented May 27, 2024 •
edited
Loading

suggestion for implementing storing the recent versions in json format

  • added conversion of existing file
  • added test cases

@MatrixCrawler MatrixCrawler mentioned this pull request May 27, 2024
Merged
@MatrixCrawler MatrixCrawler marked this pull request as ready for review May 27, 2024 08:57
@MatrixCrawler MatrixCrawler marked this pull request as draft May 27, 2024 08:58
@MatrixCrawler MatrixCrawler marked this pull request as ready for review May 27, 2024 09:08
@MatrixCrawler MatrixCrawler requested a review from MatthewJohn May 27, 2024 09:09
yermulnik
yermulnik reviewed May 27, 2024
View reviewed changes
lib/defaults.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
MatthewJohn
MatthewJohn reviewed May 27, 2024
View reviewed changes
lib/recent.go Outdated Show resolved Hide resolved
lib/recent_test.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
MatthewJohn
MatthewJohn reviewed May 27, 2024
View reviewed changes
lib/recent_test.go Show resolved Hide resolved
lib/recent_test.go Outdated Show resolved Hide resolved
lib/recent_test.go Show resolved Hide resolved
lib/recent_test.go Outdated Show resolved Hide resolved
lib/recent_test.go Outdated Show resolved Hide resolved
MatthewJohn
MatthewJohn reviewed May 27, 2024
View reviewed changes
lib/recent_test.go Outdated Show resolved Hide resolved
lib/recent_test.go Outdated Show resolved Hide resolved
MatthewJohn
MatthewJohn requested changes May 27, 2024
View reviewed changes
lib/recent.go Show resolved Hide resolved
MatthewJohn
MatthewJohn reviewed May 31, 2024
View reviewed changes
lib/defaults.go Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Show resolved Hide resolved
lib/recent_test.go Show resolved Hide resolved
@warrensbox
Copy link
Owner

warrensbox commented Jun 1, 2024 •
edited
Loading

Once you resolve the comments, it's ready to merge.

@warrensbox warrensbox added this to the Release 1.2.0 milestone Jun 1, 2024
@MatrixCrawler
Copy link
Collaborator Author

@MatthewJohn requested a change that i cannot resolve.

yermulnik
yermulnik reviewed Jun 4, 2024
View reviewed changes
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
lib/recent.go Outdated Show resolved Hide resolved
MatrixCrawler and others added 13 commits June 4, 2024 12:44
@MatrixCrawler
- doing some code optimizations
2ef3979
@MatrixCrawler @yermulnik @MatthewJohn
Apply suggestions from code review
0300c5a 
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
Co-authored-by: Matt John <matthew@dockstudios.co.uk>
@MatrixCrawler
- added pruning of old versions
f40fd11 
- made sure that the order of the recent files are kept
- renamed functions and variables to less generic
@MatrixCrawler
- fixed addRecent Method
35d53fe 
- added *recent suffix to recent version when retrieved via the getRecentVersion Method
@MatrixCrawler
- optimized tests
9538992
@MatrixCrawler
- added deleting of obsolete binaries
24890f1
@MatrixCrawler
- updating dependencies
5bcc045
@MatrixCrawler
- remove deleting of cached files and only mark the first recent 3 ve…
72e9d59 
…rsions as *recent
@MatrixCrawler
- rolled back from renaming VersionPrefix to TerraformPrefix
8a76965
@MatrixCrawler
- fix tests
d542371
@MatrixCrawler
- lowercase openTofu json attribute
4d460e3
@MatrixCrawler
- changed if statements to switch
cffeaff
@MatrixCrawler
- rebased on master and updated dependencies
30c9158
@MatthewJohn
Copy link
Collaborator

MatthewJohn commented Jun 4, 2024 •
edited
Loading

@MatthewJohn requested a change that i cannot resolve.

What do you mean, sorry? As in it's a difficult problem or Github doesn't let you resolve it?

Edit: Ignore me - found it :)

@MatrixCrawler MatrixCrawler merged commit d59ef38 into master Jun 4, 2024
3 checks passed
@MatrixCrawler MatrixCrawler deleted the recent-to-json branch June 4, 2024 11:41
@MatthewJohn MatthewJohn mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrensbox warrensbox warrensbox left review comments

@yermulnik yermulnik yermulnik approved these changes

@MatthewJohn MatthewJohn MatthewJohn approved these changes

@jukie jukie Awaiting requested review from jukie jukie is a code owner

@crablab crablab Awaiting requested review from crablab crablab is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MatrixCrawler @warrensbox @MatthewJohn @yermulnik