Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty collections and null objects are included in the JSON output #18

Closed
warriordog opened this issue Jun 27, 2023 · 1 comment
Closed

Empty collections and null objects are included in the JSON output #18

warriordog opened this issue Jun 27, 2023 · 1 comment
Assignees
@warriordog
Labels
area:code Affects or applies to the library code type:bug Something isn't working
Milestone
ActivityStreams: ...

Comments

@warriordog
Copy link
Owner

warriordog commented Jun 27, 2023 •
edited
Loading

The following behavior is incorrect, but currently displayed by the JSON implementation:

  • Properties with a null value are written to the output
  • Empty collections are written as an empty array ([])

I think both can be fixed with some changes in ASTypeConverter.
@warriordog warriordog added type:bug Something isn't working area:code Affects or applies to the library code labels Jun 27, 2023
@warriordog
Copy link
Owner Author

Should be easier to fix once #21 is complete.

@warriordog warriordog changed the title Empty collections are included in the JSON output Empty collections and null objects are included in the JSON output Jul 15, 2023
@warriordog warriordog self-assigned this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warriordog warriordog

Labels
area:code Affects or applies to the library code type:bug Something isn't working
Projects
None yet
Milestone
ActivityStreams: mimimum viable support
Development

No branches or pull requests
1 participant
@warriordog