-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary rewrite of entire json implementation #21
Comments
This was referenced Jul 5, 2023
Closed
This is actually a ton of effort, so here's a revised approach:
This approach has several downsides:
But it has several upsides, too:
Open questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The JSON-LD model, as currently designed and implemented, will not and can not work due to this open issue in
System.Text.Json
: dotnet/runtime#63791. Until that feature gap is resolved, we will need to fall back to a lower-level implementation. This is the proposed fallback:System.Text.Json
as usual.Serialize
andDeserialize
methods, which will work with JsonNode/JsonElement respectively.Read
andWrite
. Read will populate an existing object from a reader, and write will write properties into a pre-initialized JsonObject. These will allow serialization logic to be "inherited" by calling into the base class members.This rewrite will be completed in the
sample-app
branch. Work will be considered done when the sample app is able to query a simple object from a remote instance.The text was updated successfully, but these errors were encountered: