Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.1.0 #18

Merged
merged 139 commits into from
Mar 29, 2024
Merged

Release 2.1.0 #18

merged 139 commits into from
Mar 29, 2024

Conversation

dmnapolitano
Copy link
Contributor

Description

The changes in this PR create elex-solver 2.1.0 which contains our transition matrix solver used with our voterflow models! 🎉

Jira Ticket

ELEX-3031 and epic ELEX-3028

Test Steps

tox!

dmnapolitano and others added 30 commits October 6, 2023 16:11
@dmnapolitano
Adding TransitionSolver abstract base class
e0580cd
@dmnapolitano
Running pre-commit on TransitionSolver and removing unused warnings i…
37b756c 
…mport
@dmnapolitano
Modifying TransitionMatrixSolver according to some experiments I've r…
da59677 
…un and also to inherit from TransitionSolver
@dmnapolitano
Adding placeholder for prediction intervals method
3d6aef0
@dmnapolitano
Initial check-in of EI-based transition solver
9ebe5c5
@dmnapolitano
Adding some required-matching-length exceptions to EITransitionSolver
9f49d83
@dmnapolitano
Rescale if needed, check for things x units
7f965d8
@dmnapolitano
Adding _check_and_rescale() to superclass so the same check can be pe…
9e5a3fe 
…rformed before the cvxpy solver
@dmnapolitano
Cleaning up code and exception-handling with pre-commit
76f4b61
@dmnapolitano
Adding MAE computation/reporting to ETTransitionSolver
79076a7
@dmnapolitano
Adding the ability to compute a prediction (credible) interval with t…
2254a65 
…he EI solver and also experimenting with different sampler options there
@dmnapolitano
Handle zero and other weird division correctly when rescaling the per…
3aa0f5b 
…centages to sum to 1 at the unit-level
@dmnapolitano
Adding a check to make sure we have enough units
a67304f
@dmnapolitano
Silencing some warnings
e54ba85
@dmnapolitano
Increasing the target_accept on the sampler and making sure the sampl…
aedcdff 
…ing_chains argument is an int
@dmnapolitano
Trying out some more EI solver optimizations
e9fc725
@dmnapolitano
Explicitly specifying the cvxpy solver to use since the default is ab…
08401eb 
…out to change (also squashes warning)
@dmnapolitano
Fixing poorly-worded comment in transition matrix solver
3d35f67
@dmnapolitano
Default sampling chains of 2 on 2 cores
1ac1c78
@dmnapolitano
Merge pull request #16 from washingtonpost/main
07b58fd 
Sync develop with main 🎉
@dmnapolitano
Merge branch 'develop' of github.com:washingtonpost/elex-solver into …
ae0b320 
…ELEX-3031-voterflow-models
@dmnapolitano
Making sure pymc is a requirement
c87c25b
@dmnapolitano
Experimenting with drawing fewer samples, different Dirichlet alphas
8d4637d
@dmnapolitano
Semi-relaxing the check for units summing to 1 using np.allclose()
8fc068c
@dmnapolitano
Adding numpyro to the requirements
c05acde
@dmnapolitano
Test against Python 3.11 because I don't think some of the requiremen…
39c9749 
…ts are available for 3.10
@dmnapolitano
Increasing github test timeout to 10 minutes
9d595e8
@dmnapolitano
Trying a slightly-older version of numpy to be compatible with the cu…
78d5655 
…rrent version of pytensor
@dmnapolitano
Switching to HalfNormal prior instead of Gamma after preliminary eval…
54bd39f 
…uation
@dmnapolitano
Addressing some pylint complaints
5ce550c
dmnapolitano and others added 26 commits January 30, 2024 15:45
@dmnapolitano
Adding some method docstrings and return types to the transition solv…
f2d0578 
…er base class
@dmnapolitano
Writing one single docstring for fit_predict() in the base class
d62680b
@dmnapolitano
Matrix and bootstrap solvers docstrings, return types, and modifying …
9c3379d 
…the confidence interval method to return transitions
@dmnapolitano
Adding unit test for bootstrap matrix confidence interval transitions
1ac03f3
@dmnapolitano
Adding docstrings to EI transition solver and cleaning up a few others
5340492
@dmnapolitano
Making EI solver's get_transitions() method super private
7c69f88
@dmnapolitano
Adding text to the README:
160066c
@dmnapolitano
Capitalizing the 'm' in the section header
67dd426
@dmnapolitano
Removing the bootstrap matrix solver from this branch in favor of it …
fe69ce4 
…living in the ELEX-3830 branch
@dmnapolitano
Forgot to remove bootstrap mentions from the README
e9ef2ed
@dmnapolitano
Moving the EI solver to elex-voterflow-model as the EI model
92641ac
@dmnapolitano
Asking pylint to ignore missing-module-docstring
109b718
@dmnapolitano
When the Clarabel solver fails or throws a warning, chain that to a R…
70bbaf7 
…untimeError and raise the exception
@dmnapolitano
Removing get_prediction_interval() method since it hasn't been implem…
1c18883 
…ented anywhere yet
@dmnapolitano
Moving rules about matrix dimensions that are specific to voterflow o…
ffde8aa 
…ver to elex-voterflow-model
@dmnapolitano
Splitting fit_predict() into two methods, renaming 'percentages' to '…
71f29c9 
…self._betas', renaming 'weights' to 'sample_weight' to be consistent with sklearn
@dmnapolitano
Specifying return type for TransitionSolver.predict()
b5a2e07
@dmnapolitano
A version of TransitionSolver that inherets from LinearSolver
73f0c9e
@dmnapolitano
Forgot to run pre-commit
2705e8b
@dmnapolitano
Removing math to convert the coefficients to 'transitions' from Trans…
268ad15 
…itionSolver/TransitionMatrixSolver
@dmnapolitano
Cleaning up some docstring formatting and removing unnecessary property
f714ef4
@dmnapolitano
BROKEN testing the requirement of integer data and the forced-rescali…
4edb1fd 
…ng here
@dmnapolitano
FIXED updated unit tests; integer data is no longer a requirement for…
9beef48 
… transition solvers 🎉
@dmnapolitano
Adding more information to why self._check_for_zero_units() is important
06385f0
@dmnapolitano
Merge pull request #17 from washingtonpost/ELEX-3031-voterflow-models 🎉
a4e6030 
ELEX-3031: Potential Voterflow Solvers
@dmnapolitano
Preparing for 2.1.0
22d7a05
@dmnapolitano dmnapolitano requested a review from a team as a code owner March 29, 2024 18:49
@dmnapolitano dmnapolitano merged commit 2a0082d into main Mar 29, 2024
2 checks passed
@dmnapolitano dmnapolitano deleted the release/2.1.0 branch March 29, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennybronner lennybronner lennybronner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnapolitano @lennybronner