-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor address typography (postal code) #393
Comments
Thanks @mforbes! We had this reported separately a little while ago for the WSU Spine Parent Theme, but haven't addressed it anywhere. I'll work on getting things updated in the repository. In the meantime, I think it's okay to add a space before the postal code |
Oh, and:
I'm not entirely sure. It seems like original intent was for a building name or something more casual. |
The schema for Hope that helped to clear up the schema. Cheers |
I just remembered that the Spine itself is using JS to create this HTML. We'll get an update shipped shortly. |
In the current CSS, there is no space or newline added between the
addressRegion
and thepostalCode
in the spin. These elements should be styled appropriately so that the address in the spin looks good. For example, the current contact part of the spine test page rendersThere should at least be space and punctuation between the WA and the zip code, if not a new line:
Also, what is the
<span itemprop="location" content="Your location"></span>
? It is not clear from the schema what this should be.Thanks.
The text was updated successfully, but these errors were encountered: