Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor address typography (postal code) #393

Closed
mforbes opened this issue Apr 4, 2017 · 4 comments
Closed

Poor address typography (postal code) #393

mforbes opened this issue Apr 4, 2017 · 4 comments
Labels
Milestone

Comments

@mforbes
Copy link

mforbes commented Apr 4, 2017

In the current CSS, there is no space or newline added between the addressRegion and the postalCode in the spin. These elements should be styled appropriately so that the address in the spin looks good. For example, the current contact part of the spine test page renders

University Unit
Washington State University
Your PO Box
Pullman, WA99164

There should at least be space and punctuation between the WA and the zip code, if not a new line:

University Unit
Washington State University
Your PO Box
Pullman, WA
99164

Also, what is the <span itemprop="location" content="Your location"></span>? It is not clear from the schema what this should be.

Thanks.

@jeremyfelt jeremyfelt added the bug label Apr 4, 2017
@jeremyfelt
Copy link
Contributor

Thanks @mforbes! We had this reported separately a little while ago for the WSU Spine Parent Theme, but haven't addressed it anywhere.

I'll work on getting things updated in the repository. In the meantime, I think it's okay to add a space before the postal code <span> in any implementation as I think we'll use that rather than CSS to provide the space.

@jeremyfelt
Copy link
Contributor

Oh, and:

Also, what is the ? It is not clear from the schema what this should be.

I'm not entirely sure. It seems like original intent was for a building name or something more casual.

@quantumJLBass
Copy link

The schema for <span itemprop="location" content="Your location"></span> is found at http://schema.org/location located which is an accepted value under http://schema.org/PostalAddress not http://schema.org/Organization and is what the whole block is under (PostalAddress that is)

Hope that helped to clear up the schema. Cheers

@jeremyfelt
Copy link
Contributor

In the meantime, I think it's okay to add a space before the postal code in any implementation as I think we'll use that rather than CSS to provide the space.

I just remembered that the Spine itself is using JS to create this HTML. We'll get an update shipped shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants