Use x/sys for better OS coverage #6
Merged
+47
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncruces
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Yeah, I'm firmly on x/sys territory (and working to improve it).
I've argued wazero should do the same. Like, the z/OS Go toolchain isn't even publicly available, but IBM commits to x/sys to make sure it's portable. We only benefit from using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
syscalldoes not provideMprotecton freebsd and I guess won't since Golang wants to discourage using that package. And I guess @ncruces already knew this :) Had avoidedx/systo reduce external dependencies but I think for this allocator it's more important to have the proper syscall coverage, and hopefully there won't be API breaks even though it's not 1.x.