-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platforms/esp32-idf: make the code compile, add build test, cleanup #27
Conversation
igrr
commented
Dec 30, 2019
•
edited
Loading
edited
- esp32-idf: Remove unneeded files
- Simplify main.c, remove leftovers from IDF hello-world example
- Sync ESP32 examples for IDF and PIO, check in CI that the source is kept the same
- Add a build job for esp32-idf
- Run the test in QEMU for esp32
ce72bde
to
2888d54
Compare
No problem, please ping me when the master branch is fixed, I'll rebase. |
@igrr I decided to submit it partially (it's already on the master).
|
Thanks, so I understand I need to add |
Okay, have rebased, now this includes the QEMU test. |
@igrr esp32 should have enough memory (and proper heap implementation), so should work without |
@igrr this is cool, thanks for this contribution. It looks like it's almost ready to be merged, but currently the test timeouts for some reason. wasm3/platforms/esp32-pio/src/main.cpp Lines 51 to 52 in 565b585
|
Yep, the test times out because the app is not finishing (not calling exit or esp_restart). I'll push the fix in a few hours. About printing the result, i have tried this snippet, but I'm getting an error about dereferencing an incomplete type. Not sure how it compiles in Platformio... |
@igrr yeagh, in this case you need: wasm3/platforms/esp32-pio/src/main.cpp Line 14 in 565b585
|
0d41e84
to
1c4a972
Compare
@vshymanskyy Have fixed the test, and also synced IDF and PIO versions of the ESP32 example. The test job will now check that they stay in sync. |
Merged 🔥 🔥 🔥 |
@igrr does standard input work with the ESP32 qemu emulator? |
It does, sort of. I may need to implement UART FIFO timeout for the IDF UART driver to work properly, but that shouldn't be a big issue. |