Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Handle linking errors better than just a warning log #10

Open
brooksmtownsend opened this issue May 6, 2024 · 5 comments · May be fixed by #20
Open

[FEAT] Handle linking errors better than just a warning log #10

brooksmtownsend opened this issue May 6, 2024 · 5 comments · May be fixed by #20
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@brooksmtownsend
Copy link
Member

This isn't unique to the Go provider SDK, it would also be great to handle these in Rust better too. Once we have a proper way to report a failed link up to the host we should use that channel to report issues.

@brooksmtownsend brooksmtownsend added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2024
@tom-fitz
Copy link
Contributor

tom-fitz commented Jun 5, 2024

@brooksmtownsend I'd like to work on this one too! Could you possibly shed some more light on how you would like this feature to work? I think I have an idea, but would like to get a baseline first. When/how can a link fail?

@brooksmtownsend
Copy link
Member Author

Hey @tom-fitz this one might be a little more difficult to solve for the ideal case, e.g. telling the host that a link failed 🤔 Right now we just log errors if we fail to handle a link, but ideally wasmCloud itself could bubble that information up and report it as a failed link.

As far as improving this in the go provider SDK though, we could keep track of links that fail separately than the established list of links, so that we don't ignore them as duplicates. That would be a way to do some error handling when a "failed" link comes in, I just don't want to overcomplicate tracking

tom-fitz added a commit to tom-fitz/provider-sdk-go that referenced this issue Jun 5, 2024
@tom-fitz
Copy link
Contributor

tom-fitz commented Jun 5, 2024

Hey @tom-fitz this one might be a little more difficult to solve for the ideal case, e.g. telling the host that a link failed 🤔 Right now we just log errors if we fail to handle a link, but ideally wasmCloud itself could bubble that information up and report it as a failed link.

As far as improving this in the go provider SDK though, we could keep track of links that fail separately than the established list of links, so that we don't ignore them as duplicates. That would be a way to do some error handling when a "failed" link comes in, I just don't want to overcomplicate tracking

Could we not pass them back the same way the links are being passed to the cloud provider? I might be over simplifying it or not understanding completely, but I put this PR together to show you what I mean.

@tom-fitz
Copy link
Contributor

tom-fitz commented Jun 12, 2024

@brooksmtownsend Let me know if PR: #20 closes this issue and if you have anymore Go work! I like the project and would like to continue to contribute

@brooksmtownsend
Copy link
Member Author

Thank you @tom-fitz ! Apologies, this got marked off in my inbox mistakenly, taking a look now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
2 participants