feat(validation): add manifest validation #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
from
32004ba to
1ea2e06
Compare
|
Some more stuff after discussion with @brooksmtownsend that we should probably add to this:
|
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
2 times, most recently
from
2a3899d to
1661e91
Compare
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
3 times, most recently
from
1b64ffd to
70e50a8
Compare
vados-cosmonic
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
from
70e50a8 to
31ad3ea
Compare
brooksmtownsend
requested changes
May 20, 2024
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
from
31ad3ea to
1709fab
Compare
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
3 times, most recently
from
5794742 to
b969e2d
Compare
thomastaylor312
requested changes
May 20, 2024
brooksmtownsend
previously approved these changes
May 20, 2024
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
from
b969e2d to
ee19d97
Compare
This commit adds validation functions along with utility accessors to `Manifest` to enable checking WADM manifests for common errors. As the validation functions are exposed they can be used by downstream crates (ex. `wash`) to validate WADM manifests or try to catch errors *before* a manifest is used. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat=add-yaml-validation-logic
branch
from
ee19d97 to
a5a2d6d
Compare
thomastaylor312
approved these changes
May 20, 2024
|
Leaving it for @brooksmtownsend to merge since he was first reviewer |
brooksmtownsend
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This commit adds validation functions along with utility accessors to
Manifestto enable checking WADM manifests for common errors.As the validation functions are exposed they can be used by downstream crates (ex.
wash) to validate WADM manifests or try to catch errors before a manifest is used.This is up for review in draft state so we can talk about the design -- if it looks good, I'll do the following:
Related Issues
wasmCloud/wasmCloud#2009
Release Information
nextConsumer Impact
Testing
Unit Test(s)
Unit tests with fixtures have been added
Acceptance or Integration
Manual Verification