Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(async-nats): upgrade to 0.36 #409

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

brooksmtownsend
Copy link
Member

@brooksmtownsend brooksmtownsend commented Sep 4, 2024

Feature or Problem

This PR upgrades to async-nats 0.36, which will stay in draft until wasmcloud-control-interface 1.1.0 is released

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend
Copy link
Member Author

brooksmtownsend commented Sep 4, 2024

Currently failing on likely a breaking change updating to 0.36 https://github.com/nats-io/nats.rs/releases/tag/async-nats%2Fv0.36.0, which shouldn't be an issue I just need to pull out the stream message instead of deserializing the bytes directly

nats-io/nats.rs#1292

edit: Yep this was it! So instead of base64 decoding some bytes and then deserializing, now we can just deserialize. Whee

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant