fix(server): wash app delete command returns success for invalid application name #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
If an incorrect model name is passed without a version to the
wash app del <app_name>
command, it still outputs a success message ("Deleted application: <app_name>") even though this app does not exist.Related Issues
closes #502
Release Information
This PR fixes a non-critical issue. It can therefore be safely included in the next version.
Consumer Impact
This PR adapts the lookup logic for deletion requests, so that also for non-existing models a
DeleteResult::Noop
result is returned if no version is specified. This changes the current return value (which isDeleteResult::Deleted
).Currently, the documented and recommended way to delete applications is to use the wadm-client crate. The wadm-client create interprets both delete results as a success:
The
wash
CLI uses the wadm-client crate internally and outputs based on the contained result value (true
orfalse
) different output messages.Testing
Unit Test(s)
No unit tests have been added or updated.
Acceptance or Integration
An additional test case was added to the
test_delete_noop
integration test (covering the deletion of a non-existing model without specifying a version).