allow unique interfaces across duplicate links and test #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luk3ark <luk3ark@gmail.com>
|
I didn't see any changes in WADM required, seems that it treats each interface explicitly anyway. Let me know if I have missed anything other than this validation level. |
brooksmtownsend
requested changes
Dec 19, 2024
There was a problem hiding this comment.
This all looks great, we should just hold it back until wasmCloud supports this same matching validation (e.g. once wasmCloud/wasmCloud#3801 is merged and released)
|
What are we still waiting for with this? Major blocker for me at the moment |
brooksmtownsend
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related fix for wasmCloud/wasmCloud#3801