fix(ci): Builds docker images for both supported arches #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
force-pushed
the
fix/docker_build
branch
from
5fb9e8c
to
aea9adf
Compare
thomastaylor312
requested review from
autodidaddict,
brooksmtownsend and
connorsmith256
as code owners
|
I tested this on an arm device and an x86 device. You can see that it actually starts to run now with |
ricochet
requested changes
May 24, 2023
Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
fix/docker_build
branch
from
aea9adf
to
c0f9c2b
Compare
connorsmith256
approved these changes
May 24, 2023
ricochet
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The current 0.63 builds only have the arm64 architecture available for docker images
Release Information
Next. However, if we can find a way to rebuild the 0.63.1 images using this, that would be nice
Testing
This is being tested with a run of the pipeline before changing back the vars