Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Ruby dependency to rutie #52

Merged
merged 1 commit into from
May 17, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented May 17, 2021

By removing the dependency to rutie for the Ruby code (not for the
Rust code!), we can simplify our Rust code, including the Rust
doctests:

  • No need to emulate RbConfig,
  • So no need to have a build script for wasmer (build.rs),
  • No need to get rbconfig in Rakefile,
  • No need to manually add rutie to $LOAD_PATh when doctesting.

By removing the dependency to `rutie` for the Ruby code (not for the
Rust code!), we can simplify our Rust code, including the Rust
doctests:

* No need to emulate `RbConfig`,
* So no need to have a build script for `wasmer` (`build.rs`),
* No need to get `rbconfig` in `Rakefile`,
* No need to manually add `rutie` to `$LOAD_PATh` when doctesting.
@Hywan Hywan added 🎉 enhancement New feature or request 📦 component-extension About the Ruby extension written in Rust labels May 17, 2021
@Hywan Hywan self-assigned this May 17, 2021
@Hywan Hywan merged commit b036a50 into wasmerio:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 component-extension About the Ruby extension written in Rust 🎉 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant