Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx doesn't seem to work in 1.0.0 #1997

Closed
helje5 opened this issue Jan 9, 2021 · 1 comment · Fixed by #2005
Closed

nginx doesn't seem to work in 1.0.0 #1997

helje5 opened this issue Jan 9, 2021 · 1 comment · Fixed by #2005
Labels
bug Something isn't working

Comments

@helje5
Copy link
Contributor

helje5 commented Jan 9, 2021

Describe the bug

I thought I'd try nginx to try out the new Wasm container awesomeness, but it doesn't work well, or not at all:

$ wapm run nginx -p example -c nginx.conf
error: failed to run `/Users/helge/wapm_packages/_/nginx@0.1.1/nginx.wasm`
│   1: Can't instantiate emscripten module
╰─> 2: Host env initialization error: Missing export malloc

Steps to reproduce

  1. wapm install -g nginx
  2. wapm run nginx -p example -c nginx.conf

Expected behavior

An HTTP server servin' my pages.

Actual behavior

Emscripten not being available?

Additional context

This is on macOS BS Intel.
@helje5 helje5 added the bug Something isn't working label Jan 9, 2021
@MarkMcCaskey
Copy link
Contributor

Thanks for reporting this! It seems we changed some semantics when refactoring part of our emscripten implementation, I'll look into this a bit more

@MarkMcCaskey MarkMcCaskey mentioned this issue Jan 11, 2021
Merged
1 task
bors bot added a commit that referenced this issue Jan 11, 2021
@bors
Merge #2005
9054704 
2005: Improve WasmerEnv, fix emscripten imports r=syrusakbary a=MarkMcCaskey

This PR adds two new features to `WasmerEnv`:
- `alias = "alias_name"` for specifying additional names to try to find the export by
- `optional = true` for specifying that failure to find this export is okay

In addition, it fixes some breakages on emscripten introduced by migrating emscripten to `WasmerEnv` naively. I've tested this in `examples/nginx` on the `0.x` branch and Wasmer is able to run nginx again, so this resolves #1997 

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
bors bot added a commit that referenced this issue Jan 11, 2021
@bors
Merge #2005
cded1ac 
2005: Improve WasmerEnv, fix emscripten imports r=MarkMcCaskey a=MarkMcCaskey

This PR adds two new features to `WasmerEnv`:
- `alias = "alias_name"` for specifying additional names to try to find the export by
- `optional = true` for specifying that failure to find this export is okay

In addition, it fixes some breakages on emscripten introduced by migrating emscripten to `WasmerEnv` naively. I've tested this in `examples/nginx` on the `0.x` branch and Wasmer is able to run nginx again, so this resolves #1997 

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
bors bot added a commit that referenced this issue Jan 11, 2021
@bors
Merge #2005
dc91cae 
2005: Improve WasmerEnv, fix emscripten imports r=MarkMcCaskey a=MarkMcCaskey

This PR adds two new features to `WasmerEnv`:
- `alias = "alias_name"` for specifying additional names to try to find the export by
- `optional = true` for specifying that failure to find this export is okay

In addition, it fixes some breakages on emscripten introduced by migrating emscripten to `WasmerEnv` naively. I've tested this in `examples/nginx` on the `0.x` branch and Wasmer is able to run nginx again, so this resolves #1997 

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve WasmerEnv, fix emscripten imports wasmerio/wasmer
2 participants
@MarkMcCaskey @helje5