Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize js and sys tests #3152

Closed
syrusakbary opened this issue Aug 30, 2022 · 2 comments · Fixed by #3164
Closed

Standardize js and sys tests #3152

syrusakbary opened this issue Aug 30, 2022 · 2 comments · Fixed by #3164
Assignees
Labels
🎉 enhancement New feature!
Milestone

Comments

@syrusakbary
Copy link
Member

In the Wasmer API, we have two kind of tests: js and sys ones depending on the feature used.

However, both are testing the Wasmer API (which should be resilient across the js or sys feature).
In general, we should unify the crates/api/tests for both js and sys (and using the test or wasm_bindgen macro depending on the target/feature).
That way we test our that our public API is resilient

@syrusakbary syrusakbary added the 🎉 enhancement New feature! label Aug 30, 2022
@syrusakbary syrusakbary added this to the v3.0 milestone Aug 30, 2022
@fschutt
Copy link
Contributor

fschutt commented Aug 31, 2022

Ideally this should be done after #3129 is merged, but I can start working on it

@syrusakbary
Copy link
Member Author

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants