Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize between -sys and -js tests #3164

Merged
merged 17 commits into from
Sep 9, 2022
Merged

Synchronize between -sys and -js tests #3164

merged 17 commits into from
Sep 9, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Aug 31, 2022

Fixes #3152.

@fschutt fschutt requested a review from syrusakbary as a code owner August 31, 2022 12:27
syrusakbary
syrusakbary approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once tests pass!

@fschutt
Copy link
Contributor Author

fschutt commented Sep 2, 2022

@syrusakbary The only tests that don't pass right now are the ones concerning ExternRef- you said it was easy to implement this in JS, so I'm going to let them fail until ExternRef is implemented (should be done as part of this PR)

@syrusakbary syrusakbary merged commit e6857d1 into master Sep 9, 2022
@bors bors bot deleted the sync-js-sys-tests branch September 9, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize js and sys tests
2 participants
@fschutt @syrusakbary