Improve default compiler story for wasmer cli #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
This commit reenables the clif compiler as the default for wasmer cli, updates an error message, and adds a compile_error if no backends are enabled.
MarkMcCaskey
force-pushed
the
fix/default-compiler-wasmer-cli
branch
from
390d435 to
ab11144
Compare
|
bors try- |
|
bors try |
tryBuild succeeded |
syrusakbary
reviewed
Dec 4, 2019
nlewycky
approved these changes
Dec 6, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2019
1033: Improve default compiler story for wasmer cli r=MarkMcCaskey a=MarkMcCaskey This PR needs the following to be ready to ship: - [x] Verified make commands are still fine - [x] Verified this doesn't do anything bad in CI This PR adds: - compile_error if no backend is specified in wasmer.rs - readds clif as the default - improves the error message saying "specified backend not found" to include the name of the backend that it couldn't find Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <5770194+markmccaskey@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs the following to be ready to ship:
This PR adds: