-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for support of AArch64 in the llvm backend. #1044
Conversation
bors r+ |
Merge conflict |
3f7d002
to
be7505c
Compare
be7505c
to
4f39102
Compare
bors r+ |
1044: Initial commit for support of AArch64 in the llvm backend. r=nlewycky a=nlewycky # Description Enables AArch64 in the llvm backend, and inkwell when the target_arch is aarch64. Adds relevant failing spectests to the excludes.txt. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <nick@wasmer.io>
Build failed |
bors r+ |
1044: Initial commit for support of AArch64 in the llvm backend. r=nlewycky a=nlewycky # Description Enables AArch64 in the llvm backend, and inkwell when the target_arch is aarch64. Adds relevant failing spectests to the excludes.txt. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <nick@wasmer.io>
Build failed |
Given a Cargo.toml with:
when inkwell is built, both target-aarch64 and target-x86 are defined. This is due to rust-lang/cargo#4866. If the underlying LLVM was built without both X86 and AArch64 backends, this will lead to a link error. That's the cause of the windows build failure, that LLVM has the X86 backend but not the AArch64 backend. |
@nlewycky I believe we can fix this with the |
I tried implementing this a couple ways, either with build.rs printing |
bors r+ |
1044: Initial commit for support of AArch64 in the llvm backend. r=syrusakbary a=nlewycky # Description Enables AArch64 in the llvm backend, and inkwell when the target_arch is aarch64. Adds relevant failing spectests to the excludes.txt. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <nick@wasmer.io> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Build failed |
bors r+ |
1044: Initial commit for support of AArch64 in the llvm backend. r=syrusakbary a=nlewycky # Description Enables AArch64 in the llvm backend, and inkwell when the target_arch is aarch64. Adds relevant failing spectests to the excludes.txt. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <nick@wasmer.io> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
bors r- |
Canceled |
bors r+ |
1044: Initial commit for support of AArch64 in the llvm backend. r=syrusakbary a=nlewycky # Description Enables AArch64 in the llvm backend, and inkwell when the target_arch is aarch64. Adds relevant failing spectests to the excludes.txt. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <nick@wasmer.io> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Build succeeded |
Description
Enables AArch64 in the llvm backend, and inkwell when the target_arch is aarch64. Adds relevant failing spectests to the excludes.txt.
Review