-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Wasmer C API release artifacts #1233
Conversation
@@ -2,7 +2,6 @@ | |||
name = "wasmer-runtime" | |||
version = "0.13.1" | |||
description = "Wasmer runtime library" | |||
documentation = "https://wasmerio.github.io/wasmer/c/runtime-c-api/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a wrong doc link, intended to be the runtime-c-api
not for the runtime
.
We are fixing it in this PR :)
bors try |
bors try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we include the
lib/runtime-c-api/doc/
directory? I think it should be great to offer offline documentation? - Should we rename
libwasmer_runtime_c_api
tolibwasmer
? I understand it is simpler and shorter, but it's less self-describing. Could it “block” us for future projects or distributed/shared libraries?
tryBuild succeeded
|
I tried, but is not trivial to do it (since it requires doxygen installed in all the distributions OR manage more artifacts between pipelines).
I think we should keep it as simple as possible for now. Happy to revisit this in the future though :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good! My primary concern is that make build-capi
doesn't seem to build the capi 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bors r+ |
Build succeeded
|
Good job :-). |
Description
This PR updates the artifacts generated for Wasmer C API, in a way that is much more consumable, including a quick README and License.
So, after running
make capi && make build-capi
We will have awasmer-c-api.tar.gz
file with the following structureSee example generated artifact here:
wasmer-c-api.tar.gz
Review