Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in object file engine #1728

Merged
merged 6 commits into from
Oct 19, 2020
Merged

Fix bugs in object file engine #1728

merged 6 commits into from
Oct 19, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

Still fixing some bugs, work in progress

Review

  • Add a short description of the the change to the CHANGELOG.md file

Hywan
Hywan approved these changes Oct 16, 2020
View reviewed changes
@Hywan Hywan added 📦 lib-engine-staticlib About wasmer-engine-staticlib bug Something isn't working labels Oct 16, 2020
syrusakbary
syrusakbary reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the wasm_instance_get_vmctx_ptr implementation in our c-api, and the wasmer_trampoline_function_call__1 in the generated C file?

@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review October 17, 2020 00:39
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2020
@bors
Merge #1728
9f677f5 
1728: Fix bugs in object file engine r=syrusakbary a=MarkMcCaskey

Still fixing some bugs, work in progress

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build failed:

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2020
@bors @syrusakbary
Merge #1728
f61eb99 
1728: Fix bugs in object file engine r=syrusakbary a=MarkMcCaskey

Still fixing some bugs, work in progress

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus <me@syrusakbary.com>
@syrusakbary
Copy link
Member

I successfully tested wasm-validate.wasm and rustpython.wasm

@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build failed:

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2020
@bors @syrusakbary
Merge #1728
2646b94 
1728: Fix bugs in object file engine r=syrusakbary a=MarkMcCaskey

Still fixing some bugs, work in progress

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus <me@syrusakbary.com>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

bors bot added a commit that referenced this pull request Oct 17, 2020
@bors @syrusakbary
Merge #1728
931f19e 
1728: Fix bugs in object file engine r=syrusakbary a=MarkMcCaskey

Still fixing some bugs, work in progress

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus <me@syrusakbary.com>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2020

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors r+

1 similar comment
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Oct 19, 2020
@bors @syrusakbary @MarkMcCaskey
Merge #1728
669bf44 
1728: Fix bugs in object file engine r=MarkMcCaskey a=MarkMcCaskey

Still fixing some bugs, work in progress

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Syrus <me@syrusakbary.com>
Co-authored-by: Mark McCaskey <5770194+MarkMcCaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

Build failed:

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

Build succeeded:

@bors bors bot merged commit 9f7e76d into master Oct 19, 2020
@bors bors bot deleted the fix/create-exe-genearted-code-bugs branch October 19, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Hywan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working 📦 lib-engine-staticlib About wasmer-engine-staticlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCaskey @syrusakbary @Hywan