Globals are already stored inside the VMContext. #1758
Closed
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -909,8 +909,6 @@ impl VMBuiltinFunctionsArray { | |||
| /// The struct here is empty, as the sizes of these fields are dynamic, and | |||
| /// we can't describe them in Rust's type system. Sufficient memory is | |||
| /// allocated at runtime. | |||
| /// | |||
| /// TODO: We could move the globals into the `vmctx` allocation too. | |||
There was a problem hiding this comment.
Looking at InstanceHandle, it looks like globals have an extra layer of indirection on them
instance.globals_ptr() as *mut NonNull<VMGlobalDefinition>,Whereas everything else only has 1, so it looks like this comment is still valid.
We could probably fix this in the same way that #1687 is fixing memory/table
| @@ -255,7 +255,6 @@ impl Instance { | |||
| /// Return the indexed `VMGlobalDefinition`. | |||
| fn global_ptr(&self, index: LocalGlobalIndex) -> NonNull<VMGlobalDefinition> { | |||
| let index = usize::try_from(index.as_u32()).unwrap(); | |||
| // TODO: | |||
There was a problem hiding this comment.
Not sure what this TODO is referring to... maybe the double pointer thing?
|
Closing this PR as is stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I claim these two TODOs are both detritus. Change my mind 😉