-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic AddressMap support for singlepass #1870
Conversation
This reverts commit 55d001d. # Conflicts: # lib/engine/src/trap/frame_info.rs
bors try |
If there is a test available that failed before and passes now, how about adding this to the CI testing? |
That's a good idea! However doing it properly is not trivial, so probably we should address it in another PR!
Ooooops. Just fixed it to the proper issue. Thanks for the ping! |
// Generate artificial srcloc for function start/end to identify boundary | ||
// within module. It will wrap around if byte code is larger than 4 GB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reword this comment? This comment turns up cranelift source code if you search for "Generate artificial srcloc for" which is unfortunate, given that the rest of the function doesn't match anything in cranelift.
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
self.instructions_address_map.push(InstructionAddressMap { | ||
srcloc: SourceLoc::new(self.src_loc), | ||
code_offset: offset, | ||
code_len: 2, // TODO: Check this length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a problem (see earlier comment about DIV lengths).
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
bors r+ |
1870: Added basic AddressMap support for singlepass r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description This PR should fix #1856 and #1523 by adding address maps with the locations related to the traps. The PR makes the following command to pass (in debug mode): ``` cargo test --features "singlepass" --features "test-singlepass test-jit" ``` <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <me@syrusakbary.com> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Build failed: |
Merging manually, the only test that failed is because a github error (and is not critical!) |
Description
This PR should fix #1856 and #1523 by adding address maps with the locations related to the traps.
The PR makes the following command to pass (in debug mode):
Review