feat(cli) Improve environment variables parsing #2042
Merged
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following environment variables are considered incorrect: * `A`, no equal sign, * `A=`, value is missing, * `=A`, key is missing. The following environment variables are considered correct: * `A=B` with `A` for the name and `B` for the value, * `A=B=C` with `A` for the name and `B=C` for the value.
Hywan
added
🎉 enhancement
MarkMcCaskey
approved these changes
Jan 22, 2021
| &entry | ||
| ), | ||
|
|
||
| Some(position) => Ok((entry[..position].into(), entry[position + 1..].into())), |
There was a problem hiding this comment.
The actual splitting can just be done with just https://doc.rust-lang.org/std/primitive.str.html#method.split_at ; but we won't have as many error cases to report.
Just a heads up, I'm fine keeping it as-is
There was a problem hiding this comment.
We would need to deal with empty string for the left- or right-end side of the =. I think the code would not be simplified that much. Thanks for the heads-up!
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2028. In #1762 we have already improved environment variables syntax, but the same work must be done in the CLI crate.
The following environment variables are considered incorrect:
A, no equal sign,A=, value is missing,=A, key is missing.The following environment variables are considered correct:
A=BwithAfor the name andBfor the value,A=B=CwithAfor the name andB=Cfor the value.The environment variable is trimmed before being parsed with
str::trim.This PR also adds tests for the
parse_envvarfunction, which was missing.Review