-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(makefile) Simplify the prelude + build-capi
includes all available compilers
#2123
Merged
bors
merged 42 commits into
wasmerio:master
from
Hywan:feat-c-api-build-lib-with-all-compilers-and-engines
Feb 18, 2021
+330
−89
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
adb7c59
feat(makefile) Simplify conditions with `IS_*` bool variables.
Hywan 659bdb0
fix(makefile) If LLVM 10 and 11 are available, do not duplicate the `…
Hywan 7b38752
feat(makefile) Centralize the `compilers` decision in the same place.
Hywan 006c653
chore(makefile) Rename `test_compilers_engines` to `compilers_engines`.
Hywan 67a1dfe
feat(makefile) Handle the `cranelift-*` pairs in a single place.
Hywan f3c729d
feat(makefile) Handle the `llvm-*` pairs in a single place.
Hywan 1054e51
feat(makefile) Handle the `singlepass-*` pairs in a single place.
Hywan ba3fdf1
feaf(makefile) Add the `HAS_<compiler>` variables.
Hywan 06d543a
fix(makefile) Fix syntax error.
Hywan 660daba
feat(makefile) Remove `filter-out`, and clean up `capi_default_featur…
Hywan 95dcb04
feat(makefile) Define a single place to compute Cargo features.
Hywan 6721769
feat(makefile) Use comma to separate Cargo features in `compiler_feat…
Hywan 62c7889
feat(makefile) Remove extra spaces in `compilers` and `compilers_engi…
Hywan 387a753
feat(makefile) `build-capi` includes all available compilers.
Hywan f846a0d
feat(makefile) Explain `test-capi` and introduce `test-capi-all`.
Hywan d777994
doc(changelog) Add #2123.
Hywan 2e9fe35
Update Makefile
Hywan 4bcb204
fix(makefile) Add a default value to `use_system_ffi`.
Hywan 68360c8
Update Makefile
Hywan 9cc8177
!debug
Hywan f6da076
Merge branch 'feat-c-api-build-lib-with-all-compilers-and-engines' of…
Hywan 5aa1597
fix(makefile) Restore `build-capi` to build with all available compil…
Hywan 75f1502
Revert "Update Makefile"
Hywan 07efde1
feat(makefile) Raise an error if the platform is unsupported.
Hywan 404b91f
feat(makefile) Raise an error if the architecture is unsupported.
Hywan 487f78c
feat(makefile) Do not use the `ifeq ($(IS_<platform>), 0)` pattern.
Hywan 0a0b7f8
feat(makefile) Force to enable/disable a compiler with `ENABLE_*`.
Hywan ba48bc6
feat(makefile) Improve the informative introduction.
Hywan b242461
doc(makefile) Improve documentation of `test-capi`.
Hywan e056ef5
doc(changelog) Add #2123 again since it contains 2 features.
Hywan f1d9847
test(integration) Use `c++` or `clang++` to link the tests.
Hywan bed96ed
doc(makefile) Do not unfold the matrix.
Hywan da77c75
Revert "test(integration) Use `c++` or `clang++` to link the tests."
Hywan 39c1c63
fix(ci) Run integration tests with `libwasmer` with Cranelift only.
Hywan ead3139
fix(ci) Run integration tests with `libwasmer` with Cranelift only.
Hywan ed34e48
feat(makefile) Exclude LLVM from the list of compilers for the C API.
Hywan 2c374e7
Merge branch 'feat-c-api-build-lib-with-all-compilers-and-engines' of…
Hywan 59fd98b
Fix a merge conflict.
Hywan 0e99ff5
Merge branch 'master' into feat-c-api-build-lib-with-all-compilers-an…
nlewycky f92a443
Merge branch 'master' into feat-c-api-build-lib-with-all-compilers-an…
syrusakbary 0f15939
doc(makefile) Use times symbol rather than “x”.
Hywan ab79f3c
Merge branch 'feat-c-api-build-lib-with-all-compilers-and-engines' of…
Hywan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(makefile) Remove
filter-out
, and clean up `capi_default_featur…
…es`.
- wasmer-config-v0.1.0
- vmini-release-headless
- v6.0.0-beta.1
- v6.0.0-alpha.2
- v6.0.0-alpha.1
- v5.0.5-rc1
- v5.0.4
- v5.0.3
- v5.0.2
- v5.0.1
- v5.0.0
- v5.0.0-rc.1
- v4.4.0
- v4.3.7
- v4.3.6
- v4.3.5
- v4.3.4
- v4.3.3
- v4.3.2
- v4.3.1
- v4.3.0
- v4.3.0-beta.1
- v4.3.0-alpha.1
- v4.2.8
- v4.2.7
- v4.2.6
- v4.2.5
- v4.2.4
- v4.2.3
- v4.2.2
- v4.2.1
- v4.2.0
- v4.1.2
- v4.1.1
- v4.1.0
- v4.0.0
- v4.0.0-beta.3
- v4.0.0-beta.2
- v4.0.0-beta.1
- v4.0.0-alpha.1
- v3.3.0
- v3.2.1
- v3.2.0
- v3.2.0-beta.2
- v3.2.0-beta.1
- v3.2.0-alpha.1
- v3.1.1
- v3.1.0
- v3.0.3
- v3.0.2
- v3.0.1
- v3.0.0
- v3.0.0-rc.4
- v3.0.0-rc.3
- v3.0.0-rc.2
- v3.0.0-rc.1
- debug-delete-later
- 3.0.0-beta.2
- 3.0.0-beta
- 3.0.0-alpha
- 2.3.0
- 2.2.1
- 2.2.0
- 2.2.0-rc2
- 2.2.0-rc1
- 2.1.1
- 2.1.0
- 2.0.0
- 2.0.0-rc2
- 2.0.0-rc1
commit 660dababdc68debd396567b66c0431655405b493
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(No action required.) Just FYI, the reason I didn't name this compilers_engines is because we build a set of compilers and we also build a set of engines, we don't build compiler-engine pairs. This is somewhat useful if you want to build something that is known not to work because you are the developer making it work.
I think the reason behind this renaming is to specify which compilers+engines will be used not just for testing but also in the list provided over the C API, which is fine with me but that part isn't in this commit (haven't looked later in the PR yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
compilers_engines
set of pairs is only used bytest-*
rules, true, but I thought it was more meaningful to name the variable after what it contains, and not after what it is used for.If you prefer to name the variable
test_compilers_engines
, I'm fine keeping it!