Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing C API function wasm_func_copy #2346

Merged
merged 3 commits into from
May 26, 2021
Merged

Implement missing C API function wasm_func_copy #2346

merged 3 commits into from
May 26, 2021

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented May 26, 2021 •
edited
Loading

Resolves #2344

Review

  • Add a short description of the change to the CHANGELOG.md file

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Merge #2346
19dda19 
2346: Implement missing C API function `wasm_func_copy` r=MarkMcCaskey a=MarkMcCaskey

Resolves #2344 

# Review

- [x] Add a short description of the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented May 26, 2021

Build failed:

Temporarily ignore racey WASI test
d337f6c 
The new way we run tests makes this test race with itself when multiple versions
of this test are run concurrently. We disable this test for now so it doesn't
block CI
@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 26, 2021

Build succeeded:

@bors bors bot merged commit ea369c4 into master May 26, 2021
@bors bors bot deleted the add-wasm-c-api-func-copy branch May 26, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubianchi jubianchi jubianchi approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c-api: missing symbols declared in wasm.h
2 participants
@MarkMcCaskey @jubianchi