Rename wasm_instance_new()’s “traps” argument to “trap”. #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2021
2478: Rename wasm_instance_new()’s “traps” argument to “trap”. r=syrusakbary a=FGasper Issue #2472 # Description This clarifies a bit how to properly use the error-handling mechanism in `wasm_instance_new()`, which only produces 0 or 1 traps, not 2+ as the name “traps” implies. # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felipe Gasper <felipe@felipegasper.com>
FGasper
force-pushed
the
rename_traps_to_trap
branch
from
d8cd757 to
02c9eb7
Compare
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2021
2478: Rename wasm_instance_new()’s “traps” argument to “trap”. r=syrusakbary a=FGasper Issue #2472 # Description This clarifies a bit how to properly use the error-handling mechanism in `wasm_instance_new()`, which only produces 0 or 1 traps, not 2+ as the name “traps” implies. # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felipe Gasper <felipe@felipegasper.com>
|
Build failed: |
FGasper
force-pushed
the
rename_traps_to_trap
branch
from
02c9eb7 to
fcbc174
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2021
2478: Rename wasm_instance_new()’s “traps” argument to “trap”. r=syrusakbary a=FGasper Issue #2472 # Description This clarifies a bit how to properly use the error-handling mechanism in `wasm_instance_new()`, which only produces 0 or 1 traps, not 2+ as the name “traps” implies. # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felipe Gasper <felipe@felipegasper.com>
|
Build failed: |
FGasper
force-pushed
the
rename_traps_to_trap
branch
from
fcbc174 to
4255387
Compare
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make FGasper a reviewer |
|
bors r+ |
Hywan
reviewed
Jul 19, 2021
| @@ -9,6 +9,8 @@ Looking for changes that affect our C API? See the [C API Changelog](lib/c-api/C | |||
| ## **[Unreleased]** | |||
|
|
|||
| ### Changed | |||
| - [#2478](https://github.com/wasmerio/wasmer/pull/2478) Rename `traps` input to `wasm_instance_new()` to `trap`. | |||
There was a problem hiding this comment.
This is incorrect, it should have been written in the lib/c-api/CHANGELOG.md file.
There was a problem hiding this comment.
Sorry! I noticed that only after committing. Thank you for fixing it.
Hywan
added
🎉 enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2472
Description
This clarifies a bit how to properly use the error-handling mechanism in
wasm_instance_new(), which only produces 0 or 1 traps, not 2+ as the name “traps” implies.Review