-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Migrate wasmer-cli to clap from structopt #2890
Conversation
rust-toolchain
Outdated
@@ -1 +0,0 @@ | |||
1.59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo this plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good other than the removal of the rust-toolchain file.
Once it's fixed we should be good to merge
There's still a few TODOs in the change that I'd like to have clarified first, that's why it is still a draft MR. The removal of the toolchain file will not be part of the final version of this MR of course, as has nothing to do with it. |
I'd like to see a binary size of clap and structopt as well, out of curiosity. |
What about |
ed4fb52
to
2c3efeb
Compare
2c3efeb
to
8575fe1
Compare
@epilys here are the numbers for changes in binary size (measured on my x64 desktop computer with Debian 11, without llvm compiler enabled, but I think that shouldn't change a lot in this context). For transparency, this is how I collected the information:
Raw release binariesAll raw numbers in the tabe are sizes in bytes.
Stripped release binariesAll raw numbers in the tabe are sizes in bytes.
|
Superseded by #3079 |
Description
Review